Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] librdkafka static bundle fixes required for next release #916

Closed
wants to merge 4 commits into from

Conversation

edenhill
Copy link
Contributor

THIS MUST NOT BE MERGED BEFORE THE NEXT IMPORT

So what you do is, when it is time for the next librdkafka import or RC:
$ git checkout master
$ git pull --rebase origin master
$ git fetch --tags
$ git checkout impfix # this PR
$ cd kafka/librdkafka_vendor
$ ./import.sh --develop /tmp/librdkafka-static-bundle-v2.0.0-RC2.tgz # or whatever version

If everything is ok, push it:

$ git checkout import_v2.0.0-RC2 # or whatever verison it is
$ push --dry-run origin import_v2.0.0-RC2

Go to github, review, MERGE! Do not squash or rebase, MERGE!

@edenhill edenhill requested a review from emasab December 21, 2022 19:30
@emasab
Copy link
Contributor

emasab commented Jan 17, 2023

This was included, initially accidentally with RC4 in a squash-merge while migrating to SemaphoreCI, the second time with 2.0.0 the static bundle was merged correctly with a merge commit.

@emasab emasab closed this Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants