Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumer.commit() with no parameters #277

Closed
avoskresensky opened this issue Nov 10, 2017 · 2 comments
Closed

Consumer.commit() with no parameters #277

avoskresensky opened this issue Nov 10, 2017 · 2 comments
Labels

Comments

@avoskresensky
Copy link

avoskresensky commented Nov 10, 2017

I've noticed that passing calling Consumer.commit(msg=None) is a valid case. At least it's being handled in the library's code separately. I'm wondering what's the difference between doing that and calling Consumer.commit with the last read message for the "msg" argument.

It looks like it does pretty much the same thing, but then why the argument is always passed explicitly in all of the tests in examples/integration_test.py?

https://stackoverflow.com/questions/47216827/confluent-kafka-python-producer-commit-with-no-parameters

@avoskresensky avoskresensky changed the title Producer.commit() with no parameters Consumer.commit() with no parameters Nov 13, 2017
@edenhill
Copy link
Contributor

The argument-less commit() will commit all uncommitted offsets for the current assignment.

The Python integration tests are primarily to verify the APIs with a live broker environment, the actual kafka client tests reside in librdkafka's build tree and are much more detailed.
librdkafka (using this Python client) also runs the full standard Apache Kafka client system test suite in a nightly job.

@avoskresensky
Copy link
Author

Thanks @edenhill .
Could you please also comment on https://stackoverflow.com/questions/47215245/error-cb-in-confluent-kafka-python-producers-and-consumers when you have a minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants