Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageView Demo requires more configuration properties to be used within secure environment #327

Open
kamir opened this issue Mar 22, 2020 · 1 comment

Comments

@kamir
Copy link

kamir commented Mar 22, 2020

Currently, only the two properties:

  • bootstrapServers
  • schemaRegistryUrl
    are configurable via java application arguments.

It would be nice, if a properties file could be used to configure the consumer / producer of the demo applications.

@kamir
Copy link
Author

kamir commented Mar 22, 2020

Proposed solution:

Option A
Adding a third argument.
The string represents the path/filename of a properties file with all relevant configuration parameters.
In case it is not provided, demo works as until now. If it is provided,
the values in the properties file will overwrite the first two arguments.

This looks like a good short term solution.

Option B
Implement proper CLI argument handling via commons-cli.
If a generic component would be created, it could be reused in all examples.

This needs some more work, but would contribute to a better user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants