Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#336 - Remove deprecated AbstractKafkaAvroSerDeConfig usage #383

Merged
merged 2 commits into from
Mar 28, 2021
Merged

Issue#336 - Remove deprecated AbstractKafkaAvroSerDeConfig usage #383

merged 2 commits into from
Mar 28, 2021

Conversation

saurabh-slacklife
Copy link
Contributor

  1. Removed AbstractKafkaAvroSerDeConfig usage
  2. Removed unused imports.

Local tested with regular mvn lifecycle: compile and test

#336

@ghost
Copy link

ghost commented Mar 25, 2021

It looks like @saurabh-slacklife hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@saurabh-slacklife
Copy link
Contributor Author

[clabot:check]

@ghost
Copy link

ghost commented Mar 25, 2021

@confluentinc It looks like @saurabh-slacklife just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@mjsax
Copy link
Member

mjsax commented Mar 26, 2021

Thanks for the PR. I think we also need to update

  • GenericAvroScalaIntegrationTest.scala
  • SpecificAvroScalaIntegrationTest.scala

@saurabh-slacklife
Copy link
Contributor Author

Thanks for the PR. I think we also need to update

  • GenericAvroScalaIntegrationTest.scala
  • SpecificAvroScalaIntegrationTest.scala

@mjsax It's updated with scala changes.

@mjsax mjsax merged commit c9aada8 into confluentinc:6.1.1-post Mar 28, 2021
@saurabh-slacklife saurabh-slacklife deleted the bug/336-remove-deprecated-avroserde branch March 29, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants