fix: CLI commands may be terminated with semicolon+whitespace (MINOR) (…

…#4234)
confluentinc · Jan 7, 2020 · 096b78f · 096b78f
1 parent da57002
commit 096b78f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/ksql-cli/src/main/java/io/confluent/ksql/cli/console/Console.java b/ksql-cli/src/main/java/io/confluent/ksql/cli/console/Console.java
@@ -409,7 +409,7 @@ public OutputFormat getOutputFormat() {
   }
 
   private Optional<CliCmdExecutor> getCliCommand(final String line) {
-    final List<String> parts = splitByUnquotedWhitespace(StringUtils.stripEnd(line, ";"));
+    final List<String> parts = splitByUnquotedWhitespace(StringUtils.stripEnd(line.trim(), ";"));
     if (parts.isEmpty()) {
       return Optional.empty();
     }

diff --git a/ksql-cli/src/test/java/io/confluent/ksql/cli/console/ConsoleTest.java b/ksql-cli/src/test/java/io/confluent/ksql/cli/console/ConsoleTest.java
@@ -1356,6 +1356,20 @@ public void shouldSupportCmdBeingTerminatedWithSemiColon() {
     verify(cliCommand).execute(eq(ImmutableList.of("Arg0")), any());
   }
 
+  @Test
+  public void shouldSupportCmdBeingTerminatedWithSemiColonAndWhitespace() {
+    // Given:
+    when(lineSupplier.get())
+        .thenReturn(CLI_CMD_NAME + WHITE_SPACE  + "Arg0; \n")
+        .thenReturn("not a CLI command;");
+
+    // When:
+    console.readLine();
+
+    // Then:
+    verify(cliCommand).execute(eq(ImmutableList.of("Arg0")), any());
+  }
+
   @Test
   public void shouldSupportCmdWithQuotedArgBeingTerminatedWithSemiColon() {
     // Given: