Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull Queries: restructure code #3581

Closed
big-andy-coates opened this issue Oct 15, 2019 · 2 comments
Closed

Pull Queries: restructure code #3581

big-andy-coates opened this issue Oct 15, 2019 · 2 comments
Projects
Pull Queries

Comments

@big-andy-coates
Copy link
Contributor

big-andy-coates commented Oct 15, 2019 •
edited
Loading

Taking lessons learned from the poc (that's in prod ;)), we can now restructure the code to use better abstractions.

e.g. #3340 (comment)

We should also look to store data on what tables are materialized directly in a map in the engine, rather than how the StaticQueryExecutor does things.
@big-andy-coates
Copy link
Contributor Author

requires #3541

@big-andy-coates big-andy-coates mentioned this issue Oct 15, 2019
Closed
27 tasks
@big-andy-coates big-andy-coates added this to To do in Pull Queries via automation Oct 25, 2019
@big-andy-coates big-andy-coates mentioned this issue Nov 20, 2019
Open
@big-andy-coates
Copy link
Contributor Author

closing as duplicate of #3541

Pull Queries automation moved this from To do to Done Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Pull Queries
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@big-andy-coates