Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Queries: Add rate limiting to pull queries #4445

Closed
apurvam opened this issue Feb 4, 2020 · 0 comments · Fixed by #4951
Closed

Pull Queries: Add rate limiting to pull queries #4445

apurvam opened this issue Feb 4, 2020 · 0 comments · Fixed by #4951
Assignees
Labels
enhancement P0 Denotes must-have for a given milestone
Milestone

Comments

@apurvam
Copy link
Contributor

apurvam commented Feb 4, 2020

Is your feature request related to a problem? Please describe.
Right now, there is no way to limit the number of pull queries that can be run against a particular ksqlDB server. As this is an early stage feature with many non-functional unknowns around performance, cost, etc., it would be good to enable optional rate limiting so that users can try the feature without risking negative unknowns.

Describe the solution you'd like
A configurable global rate limit across all materialized state stores which throttles request rate would be a great starting point.

Describe alternatives you've considered
More fancy multi-note limits, bandwidth limits, etc., are not necessary at this point.

@apurvam apurvam added enhancement P0 Denotes must-have for a given milestone labels Feb 4, 2020
@apurvam apurvam added this to the 0.8.0 milestone Feb 4, 2020
@apurvam apurvam added this to To do in Pull Queries via automation Feb 4, 2020
@apurvam apurvam removed the P0 Denotes must-have for a given milestone label Mar 4, 2020
@vcrfxia vcrfxia modified the milestones: 0.8.0, 0.9.0 Mar 18, 2020
@vinothchandar vinothchandar moved this from To do to In progress in Pull Queries Mar 18, 2020
@vinothchandar vinothchandar moved this from In progress to To do in Pull Queries Mar 18, 2020
@MichaelDrogalis MichaelDrogalis added the P0 Denotes must-have for a given milestone label Mar 23, 2020
@vinothchandar vinothchandar changed the title Add rate limiting to pull queries Pull Queries: Add rate limiting to pull queries Mar 30, 2020
Pull Queries automation moved this from To do to Done Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement P0 Denotes must-have for a given milestone
Projects
Pull Queries
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants