Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the HTTP1 query endpoint #7203

Open
agavra opened this issue Mar 11, 2021 · 2 comments
Open

Deprecate the HTTP1 query endpoint #7203

agavra opened this issue Mar 11, 2021 · 2 comments
Assignees
Labels
P1 Slightly lower priority to P0 ;) query-engine Issues owned by the ksqlDB Query Engine team tech-debt

Comments

@agavra
Copy link
Contributor

agavra commented Mar 11, 2021

As of #4069 we have introduced a new /stream-query endpoint that leverages improved mechanics and HTTP2. Maintaining multiple such endpoints is error prone (as evidenced by #7109 and comments on #6944) so we should deprecate and remove the endpoint.

The problem is that (1) there are live use cases of that endpoint (e.g. the CLI, pull query-forwarding) and (2) lots of works has been put into optimizing /query for pull queries.

#6269 for some context on the Java Client
#6970 will also need to be tackled

@agavra agavra added P1 Slightly lower priority to P0 ;) tech-debt query-engine Issues owned by the ksqlDB Query Engine team labels Mar 11, 2021
@guozhangwang
Copy link
Contributor

Just for my understanding: besides the CLI and the pull query forwarding, what are other use cases of the /query endpoint at the moment? I'd want to have some sense on how much investment we would need for item 1) before we can finally phase out this endpoint.

@agavra
Copy link
Contributor Author

agavra commented Mar 12, 2021

@guozhangwang I believe those are the internal use cases, there may be external use cases that we're not aware of. Though @AlanConfluent brought up that there's a lot of work bringing the new endpoint to performance parity to /query which may raise the LOE estimate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Slightly lower priority to P0 ;) query-engine Issues owned by the ksqlDB Query Engine team tech-debt
Projects
None yet
Development

No branches or pull requests

3 participants