Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Schema Linking via Terraform #134

Closed
linouk23 opened this issue Nov 4, 2022 · 11 comments
Closed

Enable Schema Linking via Terraform #134

linouk23 opened this issue Nov 4, 2022 · 11 comments

Comments

@linouk23
Copy link
Collaborator

linouk23 commented Nov 4, 2022

Context

https://www.youtube.com/watch?v=xpKvLeeT_Qc

What

This is a feature request from another issue: #124 (comment)

@mihdih
Copy link

mihdih commented Jun 10, 2023

Thank you for creating the feature request :)

Just wondering, how far down is this on the roadmap? I guess just wanted to know if when will this be implemented?

@linouk23
Copy link
Collaborator Author

👋 thanks for asking @mihdih!

We can't promising anything but most likely we'll add it next quarter.

@minionOfZuul
Copy link

It would be really incredible timing for my org if this feature were getting close to ready for production. There's one more month left in the quarter. Any updates?

@linouk23
Copy link
Collaborator Author

@minionOfZuul I can't promise anything but it's currently in a code review stage.

@linouk23
Copy link
Collaborator Author

@mihdih @minionOfZuul @brunodominici @aaronphilip

We've got a quick question for you: would you prefer option #1 or option #2:

# Option #1
resource "confluent_schema_exporter" "main" {
  schema_registry_cluster {
    id = confluent_schema_registry_cluster.essentials.id
  }
  rest_endpoint = confluent_schema_registry_cluster.essentials.rest_endpoint
  credentials {
    key    = "<Schema Registry API Key for confluent_schema_registry_cluster.essentials>"
    secret = "<Schema Registry API Secret for confluent_schema_registry_cluster.essentials>"
  }
  
  name = "test-exporter"
  context = "test-context"
  context_type = "CUSTOM"
  subjects = ["foo"]
  config_nonsensitive = {
      "basic.auth.credentials.source" = "USER_INFO",
      "schema.registry.url" = "<destination sr url>"
  }
  config_sensitive = {
      "basic.auth.user.info" = "<destination api key>:<destination api secret>"
  }
  status = "RUNNING"
  reset_on_update = true
}

# Option #2 to mirror cluster link resource
resource "confluent_schema_exporter" "main" {
  schema_registry_cluster {
    id = confluent_schema_registry_cluster.essentials.id
  }
  rest_endpoint = confluent_schema_registry_cluster.essentials.rest_endpoint
  credentials {
    key    = "<Schema Registry API Key for confluent_schema_registry_cluster.essentials>"
    secret = "<Schema Registry API Secret for confluent_schema_registry_cluster.essentials>"
  }
  
  name = "test-exporter"
  context = "test-context"
  context_type = "CUSTOM"
  subjects = ["foo"]
  destination_schema_registry_cluster {
    id                 = ...
    rest_endpoint = ...
    credentials {
      key    = ...
      secret = ...
    }
  }
  status = "RUNNING"
  reset_on_update = true
  config = {
      # any SL specific settings if there're any
      "retention.ms" = "123"
  }
}


@brunodomenici
Copy link

@mihdih @minionOfZuul @brunodominici @aaronphilip

We've got a quick question for you: would you prefer option #1 or option #2:

Option 2 for me 👍

@minionOfZuul
Copy link

Same, Option 2 makes more sense to me.

@linouk23
Copy link
Collaborator Author

Update: we

Added new confluent_schema_exporter resource in a Preview lifecycle stage (see schema-linking example)
in our latest 1.52.0 version of TF Provider.

cc @mihdih @minionOfZuul @brunodominici @aaronphilip

Please let us know if there are any issues or improvements we can make. Thank you!

@mihdih
Copy link

mihdih commented Nov 21, 2023

@linouk23 Apologies for a very late response. Thank again for all the work and for adding this in. 🙇

@linouk23
Copy link
Collaborator Author

Thanks @mihdih!

@zhenli00 did all the work by himself 😁 and he also implemented a fix: #321 that we'll release in our next release.

@linouk23
Copy link
Collaborator Author

linouk23 commented Apr 5, 2024

fyi we're closing this issue as we added a corresponding resource last November in the 1.52.0 version of TF Provider: https://registry.terraform.io/providers/confluentinc/confluent/latest/docs/resources/confluent_schema_exporter

@linouk23 linouk23 closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants