Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A suggestion to avoid confusion #15

Closed
neodave opened this issue Nov 19, 2018 · 3 comments
Closed

A suggestion to avoid confusion #15

neodave opened this issue Nov 19, 2018 · 3 comments

Comments

@neodave
Copy link

neodave commented Nov 19, 2018

Your use of the term ForceCrop was not what I expected. In my use case I am having a user pick a profile pic that will be circular, so I need to force them to edit their selected photo with a circle crop. It took me awhile to understand why turning on forceCrop didn't result in that behavior, but rather forces a single crop option. IMHO ForceCrop should be named CropChoice or CropDefault.

This is an amazing framework, thank you for open sourcing it.

@n-cong
Copy link
Contributor

n-cong commented Nov 20, 2018

@neodave
Sorry for the inconvenience and Thank you for your recommendation.
Yes. You are right. Since the term ForceCrop may cause some misunderstanding, we will consider to change it in a future release.

@wakaryry
Copy link

In my usage, I want to hide the crop tab and images show the cropped when I set config.forceCropEnabled = true and config.availableCrops = [FMCrop.ratioSquare].

But now it seems I need to tap the crop button to make it cropped.

@n-cong
Copy link
Contributor

n-cong commented Nov 26, 2018

@wakaryry
Currently, we don't provide any way to hide tabs. But your PRs are always welcome :)

If you set forceCropEnabled to true then FMPhotoPicker will use the first crop option to crop images without requiring any additional action.

@congnd congnd closed this as completed Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants