Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add a light theme #163

Open
wp9015362 opened this issue Aug 30, 2015 · 6 comments
Open

Please add a light theme #163

wp9015362 opened this issue Aug 30, 2015 · 6 comments
Labels

Comments

@wp9015362
Copy link

Hello,

currently ConnectBot only has a dark theme.

Would there be any chance you could also add a light theme?

It would be much appreciated.

Regards

@wp9015362
Copy link
Author

You can see some guidelines for a light theme in the Google Material Design guidelines over there:

https://www.google.com/design/spec/style/color.html#color-themes

Regards

@wp9015362
Copy link
Author

PS:

When the light theme is in use, the FG and BG colors for the terminal should also be inverted by default of course. So, FG should be black and BG should be white.

Regards

@kruton kruton added the ux label Sep 14, 2015
@kruton
Copy link
Member

kruton commented Sep 14, 2015

Switching themes at runtime is problematic.

@wp9015362
Copy link
Author

@kruton wrote:

Switching themes at runtime is problematic.

Why?

There are several other (open source) apps which allow to switch between dark and light themes, like for example Amaze File Manager, TextSecure, spaRSS, Kore and probably many many more...

None of those have issues switching the theme while the app is running AFAICT.

You might want to have a look at Amaze File Manager, as the theme switching is working really nice in it.

Anyway, even if the theme switching would cause problems, which it obviously shouldn't as Amaze File Manager proves, then you could simply add a disclaimer to the option, which tells the user that this option requires a restart of the app and/or prompt the user to restart the app.

Regards

@alescdb
Copy link
Contributor

alescdb commented Sep 15, 2015

I've just implement a Light/Dark in one of my applications.
I had problems using it before setContentView(). It seems preferable to use it before onCreate().

  protected void onCreate( Bundle savedInstanceState )
  {
    if(setup.useLightTheme())
      setTheme(R.style.AppTheme_Light);
    super.onCreate(savedInstanceState);
  }

@oldherl
Copy link

oldherl commented Nov 12, 2020

Any follow-ups for a light color theme?

On an e-ink device, dark background doesn't look right. I'm mainly talking about the main menu and settings menu, because the console itself can be set to light background anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants