Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/custom/custom version string validation not working as intended #55

Open
neomorphic opened this issue Jan 21, 2022 · 0 comments
Open
Labels
bug Something isn't working

Comments

@neomorphic
Copy link
Contributor

The neuprintHTTP server is supposed to accept a version string as part of the custom query payload.

{
    "cypher": "MATCH (n: Neuron) WHERE  n.bodyId in [5813108066] RETURN n.bodyId AS id, n.type AS type",
    "dataset": "hemibrain",
    "version": "v1.2.1"
}

There is no combination of strings that will pass the validation for the version, so we never use it. Instead, the version is passed in as part of the dataset string, eg:

"dataset": "hemibrain:v1.2.1",

Which leads to the latest bug, passing in the following dataset version will still return a 200 response and uses the data from the most recent dataset.

"dataset": "hemibrain:v9.9.9",

So, if you were trying to query an old dataset, say “v1.1” and you entered, “v1.1.0" you would end up with data from v.1.2.1

Presumably if there are multiple datasets on a server, like vnc & abg, then if you specified a version for one of those and the version number was not valid, you might search against the completely wrong dataset

@neomorphic neomorphic added the bug Something isn't working label Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant