Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to construct 'Headers': No matching constructor signature. #231

Closed
vipero07 opened this issue Aug 11, 2022 · 1 comment
Closed

Failed to construct 'Headers': No matching constructor signature. #231

vipero07 opened this issue Aug 11, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@vipero07
Copy link
Contributor

Describe the bug
Failed to construct 'Headers': No matching constructor signature. On Chrome 56m. This is uniquely an old browser issue where it cannot construct headers when its one parameter is undefined. An easy fix is to replace any new Headers(possibleUndefined) with new Headers(possibleUndefined ?? {}).

An alternative solution is to add headers to the GrpcWebTransportOptions allowing someone to override the default behavior.

same issue from a diff repo

To Reproduce
Failed to construct 'Headers': No matching constructor signature.
This issue is specific to chrome 56m, may even be specific to a Samsung TV.

createGrpcWebTransport({
      baseUrl: import.meta.env.VITE_GRPC_ENDPOINT,
      binaryOptions: {readUnknownFields: false, writeUnknownFields: false},
    })

Environment (please complete the following information):

  • @bufbuild/connect-web@0.1.0
  • @bufbuild/protobuf@0.0.10
  • Framework and version: svelte@3.49.0
  • Browser and version: Chrome 56m

Additional context
undefined headers

@vipero07 vipero07 added the bug Something isn't working label Aug 11, 2022
@timostamm
Copy link
Member

Closed in #232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants