Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compile-time interface assertions in the generated code #101

Closed
bufdev opened this issue Feb 28, 2022 · 1 comment · Fixed by #114
Closed

Remove compile-time interface assertions in the generated code #101

bufdev opened this issue Feb 28, 2022 · 1 comment · Fixed by #114

Comments

@bufdev
Copy link
Member

bufdev commented Feb 28, 2022

var _ PingServiceClient = (*pingServiceClient)(nil) // verify interface implementation

We already get this via NewPingServiceClient - this will fail if pingServiceClient doesn't implement PingServiceClient. If this assertion fails, we have a bug in our generated code.

@akshayjshah
Copy link
Member

Yep, makes sense. Think this was a remnant of a time when we were returning a concrete type from NewXYZClient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants