Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Compressor.ShouldCompress? #107

Closed
bufdev opened this issue Mar 2, 2022 · 2 comments
Closed

Remove Compressor.ShouldCompress? #107

bufdev opened this issue Mar 2, 2022 · 2 comments

Comments

@bufdev
Copy link
Member

bufdev commented Mar 2, 2022

I get the idea behind "don't compress if it's not worth it", but this felt automagical to me, and I might be surprised as a user debugging this - I would argue that if someone requests compression, we should compress.
@bufdev
Copy link
Member Author

bufdev commented Mar 2, 2022

Add compression threshold

@akshayjshah
Copy link
Member

Fixed in #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akshayjshah @bufdev