Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove external_go_types flag and make this the default #70

Closed
bufdev opened this issue Feb 12, 2022 · 2 comments · Fixed by #73
Closed

Remove external_go_types flag and make this the default #70

bufdev opened this issue Feb 12, 2022 · 2 comments · Fixed by #73

Comments

@bufdev
Copy link
Member

bufdev commented Feb 12, 2022

We want to encourage this method of adoption going forward, and it is strictly cleaner in my view. Generating grpc/twirp alongside go was always a hack IMO.

@amckinney
Copy link
Contributor

This isn't that crazy - this means the plugin will always generate code that will import the Go types from another package. If a user ever has a compelling reason to generate the code in the same package, we could roll out a flag that does the opposite (e.g. use_go_package or something along those lines), but we might never need to.

@akshayjshah
Copy link
Member

akshayjshah commented Feb 15, 2022

Making this the default definitely makes sense, I can open a PR for that. Do we really want to remove this option altogether?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants