Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update connect-kotlin code generation to run within Gradle build #228

Open
pkwarren opened this issue Feb 29, 2024 · 0 comments
Open

Update connect-kotlin code generation to run within Gradle build #228

pkwarren opened this issue Feb 29, 2024 · 0 comments

Comments

@pkwarren
Copy link
Contributor

There have been issues in the past w/ crosstests, Maven, and other build flows where the Makefile is used but is missing required code generation dependencies (you have to manually add the generate prerequisite - see #95 for an example).

Ideally code generation would work in connect-kotlin so any user could run ./gradlew build and get a successful build without having to find the appropriate make targets. It could configure this so the compileKotlin gradle task requires code generation first.

This should be pretty easy to automate (we might even want to look at the buf gradle plugin for this) and it would reduce maintenance long term.

bufbuild/protovalidate-java#46 is an example of this migration for another project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant