Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems updating dependencies #99

Closed
nomad-software opened this issue Apr 21, 2023 · 11 comments
Closed

Problems updating dependencies #99

nomad-software opened this issue Apr 21, 2023 · 11 comments

Comments

@nomad-software
Copy link

There seems to be a problem when trying the following command in projects that import this library. This is the case for all projects I've tried so far.

go get -u ./...

github.com/<user>/<project> imports
	github.com/bufbuild/connect-opentelemetry-go imports
	go.opentelemetry.io/otel/metric/global: cannot find module providing package go.opentelemetry.io/otel/metric/global

The issue seems to be that the upstream opentelemetry.io library moved the metric directory in an update and then moved it back in another. Creating a conflict somewhere.

Can you please take a look and maybe update the dependencies of this library so it pulls in the correct sdk version please?

@thesiti92
Copy link

installing the lib is also broken for me

@joshcarp
Copy link
Contributor

It seems like the global package is removed in a release candidate v1.15.0-rc.2

I don't think go mod would update to this version automatically, and it breaks when I run go get go.opentelemetry.io/otel/metric@v1.15.0-rc.2.
Because this is a release candidate the connect-opentelemetry-go library will not depend on it until it's released

@nomad-software
Copy link
Author

So what's the solution? Any project that imports this library has issues updating dependencies.

This library has a version of v0.1.0 so it's beta itself, so why not use the release candidate if it at least fixes this library?

@joshcarp
Copy link
Contributor

Hey @nomad-software, are you using vendor?

@joshcarp
Copy link
Contributor

I will be releasing a minor version that depends on the opentelemetry rc version so that should fix this problem

@nomad-software
Copy link
Author

Hey @nomad-software, are you using vendor?

Hi, yes I am vendor'ing dependencies.
I've removed the vendor folder and tried again to update and get the same error.

@nomad-software
Copy link
Author

I will be releasing a minor version that depends on the opentelemetry rc version so that should fix this problem

Looks like a new version of opentelemetry has just dropped:

https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.15.0

@Tochemey
Copy link
Contributor

Tochemey commented May 2, 2023

Yeah a quick update is needed here because the otel metric api has changed a bit and it broke my project when using connect-otel. cc @joshcarp

@nomad-software
Copy link
Author

Looks like another opentelemetry update has been released addressing build failures:

https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.15.1

@joshcarp
Copy link
Contributor

joshcarp commented May 4, 2023

I've released https://github.com/bufbuild/connect-opentelemetry-go/releases/tag/v0.2.0 which depends on otel-go v1.15.1/v0.38.1

@joshcarp
Copy link
Contributor

Closing this issue as OpenTelemetry-go is now stable and the latest release https://github.com/bufbuild/connect-opentelemetry-go/releases/tag/v0.3.0 depends on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants