Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

[apps, client, node] Existing validation in middleware #1158

Closed
LayneHaber opened this issue May 23, 2020 · 0 comments · Fixed by #1159
Closed

[apps, client, node] Existing validation in middleware #1158

LayneHaber opened this issue May 23, 2020 · 0 comments · Fixed by #1159
Assignees
Labels
Bug Something isn't working Chore Devops or refactoring task p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers.

Comments

@LayneHaber
Copy link
Contributor

Move all existing validation from event listeners to middleware to avoid various race conditions. Related to but distinct from #1116 (and associated PRs), because it only moves existing offchain validation to middlewares

@LayneHaber LayneHaber added Bug Something isn't working p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers. Chore Devops or refactoring task labels May 23, 2020
@LayneHaber LayneHaber self-assigned this May 23, 2020
@LayneHaber LayneHaber added this to In progress in Sprint Task Workboard May 23, 2020
Sprint Task Workboard automation moved this from In progress to Done (Merged or Closed, not yet added to Release Notes) May 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working Chore Devops or refactoring task p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers.
Projects
No open projects
Sprint Task Workboard
  
Done (Merged or Closed, not yet added...
Development

Successfully merging a pull request may close this issue.

1 participant