Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[contracts] Set origin properties on fulfill #865

Closed
LayneHaber opened this issue Mar 17, 2022 · 0 comments
Closed

[contracts] Set origin properties on fulfill #865

LayneHaber opened this issue Mar 17, 2022 · 0 comments
Assignees
@LayneHaber @liu-zhipeng
Labels
Enhance 🧘 Issue type: Enhancement Request

Comments

@LayneHaber
Copy link
Contributor

Should set the sender and originDomain for the slow-liquidity path of fulfill to allow permissioned calls to pass by checking these properties. They can be accessed via reentrancy a-la ReentrancyGuard or the L2CrossDomainMessenger from optimism. These should be stored in a single storage slot (could make use of TypedMemView library).

Names may be off depending on #859
@LayneHaber LayneHaber added Enhance 🧘 Issue type: Enhancement Request Amarok labels Mar 17, 2022
@LayneHaber LayneHaber mentioned this issue Mar 24, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LayneHaber LayneHaber

@liu-zhipeng liu-zhipeng

Labels
Enhance 🧘 Issue type: Enhancement Request
Projects
Priority Rank
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LayneHaber @liu-zhipeng