Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[router] Do not execute if Nomad is down #1007

Closed
Tracked by #990
rhlsthrm opened this issue Apr 19, 2022 · 3 comments · Fixed by #1130
Closed
Tracked by #990

[router] Do not execute if Nomad is down #1007

rhlsthrm opened this issue Apr 19, 2022 · 3 comments · Fixed by #1130
Assignees
Labels
Enhance 🧘 Issue type: Enhancement Request

Comments

@rhlsthrm
Copy link
Collaborator

Check Nomad SDK:

If you run 'checkHomes' on the SDK and provide it a list of networks, then you can access 'blacklist' value which is a set of Failed homes

@alexwhte alexwhte added this to the 🐺 🚩 Public Testnet MVP milestone Apr 29, 2022
@alexwhte
Copy link
Contributor

alexwhte commented Apr 29, 2022

@rhlsthrm Do we need error handling for this in Connext Bridge UI?

edit: nvm, commented in master #990

@rhlsthrm
Copy link
Collaborator Author

@rhlsthrm Do we need error handling for this in Connext Bridge UI?

edit: nvm, commented in master #990

This needs a matching task in the SDK because the SDK should also implement this functionality.

@base0010 base0010 linked a pull request May 10, 2022 that will close this issue
4 tasks
@base0010
Copy link
Contributor

After looking at the nomad sdk not convinced that checkHomes is going to give us the correct state of if the destination chain is processing nominally. Needs clarification, but a shared utility that keeps track of the latest block hash of a updater committed root. Then we can have simple logic to compare that to block hash of now. If there is a significant n block lag (tbd what this measure exactly should be and if it needs be dynamic) we know the destination chain is down.

@alexwhte alexwhte removed this from the 📣 🐺 Public Testnet Live milestone May 24, 2022
@alexwhte alexwhte added subtask Enhance 🧘 Issue type: Enhancement Request labels May 24, 2022
rhlsthrm pushed a commit that referenced this issue Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhance 🧘 Issue type: Enhancement Request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants