1226 strict versioning #1314
Merged
1226 strict versioning #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liu-zhipeng
reviewed
May 30, 2022
Fix renaming (backend -> cartographer)
1097 bidversion
liu-zhipeng
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Routers should be prevented from bidding if the contracts are updated and they have not made prerequisite updates in their offchain logic. To fix this, we add versioning to all of the nomad router contracts. This can be leveraged in offchain checks to prevent bidding with non-compatible contract versions
Type of change
High-level change(s) description - from the user's perspective
VERSION()getter to theIConnextHandlercontract.Related Issue(s)
Fixes #1226
Related pull request(s)