Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executor unit tests #1383

Merged
merged 3 commits into from
Jun 10, 2022
Merged

Executor unit tests #1383

merged 3 commits into from
Jun 10, 2022

Conversation

wanglonghong
Copy link
Collaborator

@wanglonghong wanglonghong commented Jun 8, 2022

Description

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)

Fixes

Related pull request(s)

@wanglonghong wanglonghong linked an issue Jun 8, 2022 that may be closed by this pull request
@wanglonghong wanglonghong marked this pull request as ready for review June 9, 2022 17:12
Copy link
Contributor

@jakekidd jakekidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to handle the edge case I mentioned here

Copy link
Contributor

@jakekidd jakekidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, edge case is invalid - we're passing in msg.value as amount. looks good!

@LayneHaber LayneHaber mentioned this pull request Jun 10, 2022
8 tasks
@wanglonghong wanglonghong merged commit f888f61 into main Jun 10, 2022
@wanglonghong wanglonghong deleted the 1295-Executor-unit-test branch June 10, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Executor
4 participants