Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1328 routers facet #1390

Merged
merged 2 commits into from
Jun 13, 2022
Merged

1328 routers facet #1390

merged 2 commits into from
Jun 13, 2022

Conversation

LayneHaber
Copy link
Contributor

Description

Adds remainder of router facet unit tests.

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

High-level change(s) description - from the user's perspective

Unit tests

Related Issue(s)

Fixes #1328

Related pull request(s)

Copy link
Collaborator

@wanglonghong wanglonghong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@LayneHaber LayneHaber merged commit d1fd496 into main Jun 13, 2022
@LayneHaber LayneHaber deleted the 1328-routers-facet branch June 13, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test RoutersFacet
3 participants