1404 race condition in cartographer subgraph queries #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a36e884.
rhlsthrm
approved these changes
Jun 14, 2022
preethamr
deleted the
1404-race-condition-in-cartographer-subgraph-queries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a race condition between the cartographer queries to origin and destination side of the transfer. The end state of the transfer in the DB differs depends on the ordering of these two queries.
Type of change
High-level change(s) description - from the user's perspective
Resolve race conditions and allow origin and destination side updates to DB be idempotent and order independent.
Related Issue(s)
#1404
Fixes
#1404
Related pull request(s)