Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor nomadContext #1427

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Refactor nomadContext #1427

merged 3 commits into from
Jun 17, 2022

Conversation

wanglonghong
Copy link
Collaborator

@wanglonghong wanglonghong commented Jun 16, 2022 •
edited

Description

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)

Fixes

Related pull request(s)

@wanglonghong wanglonghong marked this pull request as ready for review June 16, 2022 16:55
base0010
base0010 approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@base0010 base0010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@base0010 base0010 merged commit aa10a1a into main Jun 17, 2022
@wanglonghong wanglonghong deleted the refactor-bridge-context branch September 28, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@base0010 base0010 base0010 approved these changes

@rhlsthrm rhlsthrm Awaiting requested review from rhlsthrm

Assignees

@wanglonghong wanglonghong

@base0010 base0010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wanglonghong @base0010