Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ankr #1439

Merged
merged 1 commit into from
Jun 21, 2022
Merged

remove ankr #1439

merged 1 commit into from
Jun 21, 2022

Conversation

carlomazzaferro
Copy link
Collaborator

Description

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)

Fixes

Related pull request(s)

wanglonghong
wanglonghong approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@wanglonghong wanglonghong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have to figure out why nomadContext throws and router exits and how we can handle this.

@carlomazzaferro carlomazzaferro merged commit ffe6686 into main Jun 21, 2022
@wanglonghong wanglonghong linked an issue Jun 21, 2022 that may be closed by this pull request
Router constantly restarting #1433
Closed
@sanchaymittal sanchaymittal deleted the remove-ankr branch September 29, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanglonghong wanglonghong wanglonghong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Router constantly restarting
2 participants
@carlomazzaferro @wanglonghong