Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure domain is supported as sanity check in execute #1512

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

jakekidd
Copy link
Contributor

Description

Seeing this error:
image

Which occurs in the catch block in packages/agents/lighthouse/src/lib/operations/cartographer.ts.

      } catch (error: any) {
        logger.error("Error Cartographer Binding", requestContext, methodContext, jsonifyError(error as NxtpError), {
          transaction,
        });
      }

It seems it's likely being thrown here, in packages/agents/lighthouse/src/lib/operations/relayer.ts.

  const destinationConnextAddress = config.chains[args.params.destinationDomain].deployments.connext;

I guess we're just not checking beforehand that a domain for a given transfer is supported. While all domains should be supported in theory, we should still catch this case especially for debugging our staging environment / broken configurations.

Type of change

Fire off an error, DomainNotSupported, if we don't have a given transfer's destination domain configured.

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

@jakekidd jakekidd added the Bug Issue type: Bug label Jul 14, 2022
@rhlsthrm rhlsthrm merged commit fb7d43b into main Jul 15, 2022
@rhlsthrm rhlsthrm deleted the handle-unsupported-domains branch July 15, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issue type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants