Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically named tests are missing #39

Open
dvirtz opened this issue May 22, 2024 · 2 comments
Open

Dynamically named tests are missing #39

dvirtz opened this issue May 22, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@dvirtz
Copy link

dvirtz commented May 22, 2024

Dynamically named tests like

void test("JSON tests", async (context) => {
  const input = ...;
  await context.test(`Converts ${input} parquet to JSON`, async () => {
  ...
  });
});

don't appear in the test explorer although they do run
image

And if there's a failure I only get a 1 subtest failed message without any other details.

@connor4312
Copy link
Owner

This is because tests are parsed from the AST, and it doesn't do any evaluation.

At some point I will probably port my evalution logic from https://github.com/microsoft/vscode-extension-test-runner/blob/main/src/extract/evaluate.ts into this

@connor4312 connor4312 added the enhancement New feature or request label May 22, 2024
@dvirtz
Copy link
Author

dvirtz commented May 22, 2024

Thanks. I previously used https://marketplace.visualstudio.com/items?itemName=Orta.vscode-jest which also supports this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants