Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small/Large sizing classes #4

Closed
jonjaques opened this issue Mar 25, 2015 · 2 comments
Closed

Small/Large sizing classes #4

jonjaques opened this issue Mar 25, 2015 · 2 comments

Comments

@jonjaques
Copy link
Contributor

Hello, thanks for putting this together - Looks great so far!

Do you see utility in adding some sizing classes? Most of these are appropriate for loading panes or pages currently, but some might work well inside a button or other UI elements.

I'm currently wrapping a React component around this (props for active, type) and a sizing option would be great too. I'll see if I can get to a PR tonight but just wanted to get your thoughts.

@ConnorAtherton
Copy link
Owner

Hi @jonjaques, thanks! I'm glad you like it.

I think it's a great idea. I think we can add a class .small that just uses a different size defined in the file.

@jonjaques
Copy link
Contributor Author

Cool, I'll see what I can whip up tonight. Here's the react lib btw: http://jonjaques.github.io/react-loaders/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants