Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gemspec is missing #67

Closed
til opened this issue Aug 6, 2012 · 4 comments
Closed

.gemspec is missing #67

til opened this issue Aug 6, 2012 · 4 comments

Comments

@til
Copy link

til commented Aug 6, 2012

It would be nice if there was a way to include the latest development version of rb-readline in a project that uses bundler with gem 'rb-readline', :git => '...', but as far as I understand that would require a .gemspec file ( http://yehudakatz.com/2010/04/02/using-gemspecs-as-intended/ ).

@luislavena
Copy link
Collaborator

Hello,

Funny you link to Yehuda post, please see my comments in response to him about that.

gemspec are build artifacts and because of that, shouldn't be under version control.

If you send a patch that avoid the duplication of the Gem::Specification between the rakefile and the gemspec and do not affect other aspects of the workflow I will include it.

Cheers.

@til
Copy link
Author

til commented Aug 6, 2012

Oh - sorry about that, funny indeed. I got so used to being able to specify a git repo in a bundler Gemfile that I took it for granted that it is standard and thought a missing gemspec is just an oversight. I should have read all of the discussion below that blog post before making dumb requests.

@luislavena
Copy link
Collaborator

@til is not a dumb request, is a different approach of development that I'm not fond with. It assumes a workflow where you use gem build to build your gems, I rather prefer Gem::PackageTask so I can package a zip file too.

gem build doesn't provide that, and I need to type more 😉

Still, as said before, if you send a pull request that creates the gemspec, remove the duplication in the rakefile and I can still benefit from rake package to generate my zip file and the gem, I will commit it.

Hint: you can use Gem::Specification.load to load the gemspec from the file.
Hint2: you can freely move rbreadline version information into it's own file so require is more easy.

Knock yourself out 😃

@til
Copy link
Author

til commented Aug 6, 2012

Thanks for the hints, I want to look into it, but no guarantees ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants