Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't be able to highlight two items in list-group #39

Closed
louy opened this issue Oct 16, 2015 · 5 comments
Closed

Shouldn't be able to highlight two items in list-group #39

louy opened this issue Oct 16, 2015 · 5 comments
Assignees
Labels

Comments

@louy
Copy link

louy commented Oct 16, 2015

Hi,

If you look at native UI components in OSX, you can't highlight two list items at the same time. The experience feels really weird when I have a selected item and I click on another one and both get highlighted.

I see two solutions here:

  1. Don't highlight on .list-group-item:active (Finder.app behaves like this in sidebar)
  2. Remove highlight on .list-group:active .list-group-item.selected:not(:active) (Finder.app behaves like this with folder content)
@connors connors added the css label Oct 16, 2015
@connors connors self-assigned this Oct 16, 2015
@connors
Copy link
Owner

connors commented Oct 16, 2015

Good catch. I actually see a few things wrong with my code here. I'll take a look this weekend.

@louy
Copy link
Author

louy commented Oct 16, 2015

👍 I solved it like this for now.

screen shot 2015-10-17 at 01 43 12

@connors
Copy link
Owner

connors commented Oct 17, 2015

Fixed in d017253.

@connors connors closed this as completed Oct 17, 2015
@louy
Copy link
Author

louy commented Oct 17, 2015

👍
I did something similar in my new app Lawha.
I had to rely on javascript because :hover doesn't work with mousedown.
Specifically here.

Thanks for this awesome project btw 😊

@connors
Copy link
Owner

connors commented Oct 17, 2015

👍 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants