Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean all of the data #42

Closed
3 tasks done
conorgil opened this issue May 11, 2018 · 5 comments
Closed
3 tasks done

Clean all of the data #42

conorgil opened this issue May 11, 2018 · 5 comments
Assignees
@conorgil
Labels
data Data sources, cleanliness, etc
Milestone
Initial release t...

Comments

@conorgil
Copy link
Owner

conorgil commented May 11, 2018 •
edited

We discovered through user testing that the data from twofactorauth.org needs lots of TLC for it to be actionable for users of 2FAN. This issue is to document some of those current issues and brainstorm ways to manually or automatically clean up the data. Where possible, improvements should be shared upstream with twofactorauth.org

  • change linkedin.com to www.linkedin.com
  • chase.com and several other sites have a doc entry that is actually a local path. This points to a page on twofactorauth.org, but the doc field should be a FQDN. Fix these entries.
  • create PRs on twofactorauth.org for these changes
@conorgil
Copy link
Owner Author

This is the commit that changed the URLs to Notes from FQDN to relative paths: 2factorauth/twofactorauth@146fa92

@conorgil conorgil added this to the Initial release to friends milestone May 13, 2018
@conorgil conorgil self-assigned this May 13, 2018
@conorgil
Copy link
Owner Author

I did not add entries for all Google subdomains, but did update the existing entry for gmail.com to mail.google.com instead

@conorgil
Copy link
Owner Author

This issue should be decomposed into issues specifically for each remaining bullet item.

This was referenced May 16, 2018
Open
Open
@conorgil
Copy link
Owner Author

Reopened because I realized that I hadn't created PRs for twofactorauth.org to share the changes upstream.

@conorgil conorgil reopened this May 16, 2018
@conorgil conorgil added the data Data sources, cleanliness, etc label May 16, 2018
@conorgil
Copy link
Owner Author

conorgil commented Jun 7, 2018

PRs:

@conorgil conorgil closed this as completed Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conorgil conorgil

Labels
data Data sources, cleanliness, etc
Projects
None yet
Milestone
Initial release to friends
Development

No branches or pull requests
1 participant
@conorgil