Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace rustc-serialize with serde #17

Closed
dtolnay opened this issue Apr 30, 2017 · 4 comments
Closed

replace rustc-serialize with serde #17

dtolnay opened this issue Apr 30, 2017 · 4 comments
Labels
assigned enhancement

Comments

@dtolnay
Copy link

dtolnay commented Apr 30, 2017 •
edited by conradkleinespel

It has been deprecated: announcement.

Is there any functionality you would require from another library before this would be possible?
@conradkleinespel
Copy link
Owner

@dtolnay Thanks for reporting that ! 👍 ❤️

Are you, by any chance, available to work on migrating Rooster to Serde? If not, no worries, I know we all have plenty of things on our minds 😉

@dtolnay
Copy link
Author

dtolnay commented Apr 30, 2017

No I'll leave it to you or one of the other contributors. It is not urgent of course.

@conradkleinespel
Copy link
Owner

@dtolnay Good to know ! Thanks again for reporting 😃

@conradkleinespel conradkleinespel changed the title Drop rustc-serialize dependency replace rustc-serialize with serde May 11, 2017
@conradkleinespel
Copy link
Owner

conradkleinespel commented May 11, 2017 •
edited

Quick recap of the work that needs to be done here.

Tasks:

  • replace rustc-serialize with serde and serde_json
  • bump the Rooster version to 2.5.1 in Cargo.toml so I can publish the new version to crates.io
  • add yourself to the contributors' list in README.md in alphabetical order

If you have any questions, just let us know and we'll jump in to help.

@Eternity-Yarr Eternity-Yarr mentioned this issue Jul 15, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assigned enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@conradkleinespel @dtolnay