Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendoring #41

Merged
merged 3 commits into from Oct 28, 2017
Merged

Vendoring #41

merged 3 commits into from Oct 28, 2017

Conversation

yamnikov-oleg
Copy link
Contributor

All the dependencies are stores in the vendor directory.

Except xcb. Until the author releases the latest patch (which makes sources generation deterministic to satisfy cargo's checksum test) and until both x11-clipboard and clipboard crates update their dependency version, xcb sources should live in the patch/rust-xcb directory, which is just a clone of v0.7.7 with a patch applied. But when xcb is updated, this directory and the [replace] section in Cargo.toml may be removed.

A copy of xcb is still present in vendor/xcb because cargo for some reason wants to see it there but doesn't use it.

You might probably want to leave a note for contributors to run cargo-vendor after updating dependencies :)

Resolves #36

@conradkleinespel
Copy link
Owner

Thanks a lot @yamnikov-oleg ! I will have a look at that shortly and merge ASAP ! 👍 ❤️

@conradkleinespel
Copy link
Owner

Hey @yamnikov-oleg ! Sorry for taking so long on this PR ! But your awesome work is paying off: just saw that your fix was merged in xcb, which means vendoring gets easier for Rooster. Nice ! 👍

I've removed the patched version of xcb and will merge now.

Thanks so much for your help ! 😃

@conradkleinespel conradkleinespel merged commit f1e11db into conradkleinespel:master Oct 28, 2017
@conradkleinespel
Copy link
Owner

@yamnikov-oleg I'll be updating dependencies now, so we can already see your work actually being useful as we update stuff :) Thanks for making it easier to audit updates. This change was needed so much ! :)

@conradkleinespel
Copy link
Owner

@yamnikov-oleg Woops, made a mistake by thinking xcb was fixed. Your fix was merged but not yet pushed to crates.io : https://github.com/rtbo/rust-xcb/issues/48

@conradkleinespel
Copy link
Owner

@yamnikov-oleg I'm bringing your patch back in Rooster for now and will remove it next time xcb is updated on crates.io :)

@yamnikov-oleg
Copy link
Contributor Author

@conradkdotcom I'm glad I've been helpful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants