Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbtileserver and nginx unit #97

Closed
catalinconstant opened this issue Feb 17, 2020 · 3 comments
Closed

mbtileserver and nginx unit #97

catalinconstant opened this issue Feb 17, 2020 · 3 comments

Comments

@catalinconstant
Copy link

catalinconstant commented Feb 17, 2020

It is possible to have an mbtileserver version o that will work with Nginx UNIT ?
https://unit.nginx.org/howto/samples/#sample-go
Thank you

@brendan-ward
Copy link
Collaborator

We'd have to switch to using UNIT as the web framework instead of echo. I don't see the advantage after reading through the UNIT docs; is there something obvious I'm missing?

@catalinconstant
Copy link
Author

catalinconstant commented Feb 17, 2020

Currently I am using tileserver-gl which use express framework, it was very easy to make it work with nginx UNIT just few lines of code

const {
createServer,
IncomingMessage,
ServerResponse,
} = require('unit-http')
require('http').ServerResponse = ServerResponse
require('http').IncomingMessage = IncomingMessage
const express = require('express')
const app = express()

and few more tweaks.
I was thinking that this is possible with echo framework in GO without changing the application just the http handling through unit-http.
In my oppinion UNIT clear has some advantage as an application server orchestarting different microservices from a single point.
Since I am quite new to GO I did not know the implications for mbtileserver.
Anyway, I started testing mbtileserver and I am quite impresed by its performance.

@brendan-ward
Copy link
Collaborator

Closing due to lack of activity. I don't have the bandwidth nor interest at this time to implement UNIT support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants