Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialization of StableCheckpoint and Certificate inefficient #400

Open
ranchalp opened this issue Apr 11, 2023 · 0 comments
Open

Serialization of StableCheckpoint and Certificate inefficient #400

ranchalp opened this issue Apr 11, 2023 · 0 comments
Labels
backlog To address eventually, not necessarily now cleanup good first issue Good for newcomers

Comments

@ranchalp
Copy link
Contributor

ranchalp commented Apr 11, 2023 •
edited
Loading

According to the cbor implementors for Go, the method em, err := cbor.CoreDetEncOptions().EncMode() (used in Certificate and StableCheckpoint serializations) should be called as little as possible for performance, as done for LeaderSelectionPolicy. This must be updated in the serialize methods of StableCheckpoint.
@ranchalp ranchalp added good first issue Good for newcomers backlog To address eventually, not necessarily now cleanup labels Apr 11, 2023
@ranchalp ranchalp changed the title Serialization of StableCheckpoint inefficient Serialization of StableCheckpoint and Certificate inefficient Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog To address eventually, not necessarily now cleanup good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ranchalp