Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename certificate variables in Orderers generic data #439

Open
ranchalp opened this issue May 10, 2023 · 2 comments
Open

Rename certificate variables in Orderers generic data #439

ranchalp opened this issue May 10, 2023 · 2 comments
Labels
backlog To address eventually, not necessarily now cleanup

Comments

@ranchalp
Copy link
Contributor

Now the ordering module is generalized to order arbitrary data, not just availability certificates.
We could rename variables that refer to former certificates, like CertRequested (and related variables) correspondingly to something along the lines of DataRequested or similar.

Originally posted by @matejpavlovic in #436 (comment)
@ranchalp ranchalp mentioned this issue May 10, 2023
Merged
@ranchalp
Copy link
Contributor Author

This comment should also be taken into consideration for this issue.

@ranchalp
Copy link
Contributor Author

Also: this minor correction

@ranchalp ranchalp added cleanup backlog To address eventually, not necessarily now labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog To address eventually, not necessarily now cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ranchalp