Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double point for twisted Edwards in std/ uses Add(P,P) instead of doubling formula #114

Closed
ThomasPiellard opened this issue Jun 30, 2021 · 0 comments · Fixed by #126
Closed

Double point for twisted Edwards in std/ uses Add(P,P) instead of doubling formula #114

ThomasPiellard opened this issue Jun 30, 2021 · 0 comments · Fixed by #126
Assignees
@ThomasPiellard
Labels
new feature

Comments

@ThomasPiellard
Copy link
Collaborator 

func (p *Point) Double(cs *frontend.ConstraintSystem, p1 *Point, curve EdCurve) *Point {
	p.AddGeneric(cs, p1, p1, curve)
}

The proper doubling formula should be used to reduce the number of constraints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasPiellard ThomasPiellard

Labels
new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v0.5.0 Consensys/gnark
1 participant
@ThomasPiellard