Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: handle windows-style path trimming in log #400

Closed
gbotrel opened this issue Nov 18, 2022 · 0 comments · Fixed by #409
Closed

bug: handle windows-style path trimming in log #400

gbotrel opened this issue Nov 18, 2022 · 0 comments · Fixed by #409
Assignees
@gbotrel
Labels
bug Something isn't working
Milestone
v0.8.0

Comments

@gbotrel
Copy link
Collaborator

gbotrel commented Nov 18, 2022 

2022-11-18T14:27:14.0700683Z Showing nodes accounting for 2, 100% of 2 total
2022-11-18T14:27:14.0701046Z       flat  flat%   sum%        cum   cum%
2022-11-18T14:27:14.0701642Z          1 50.00% 50.00%          2   100%  profile_test.(*Circuit).Define D:\a\gnark\gnark\profile\profile_test.go:17
2022-11-18T14:27:14.0702265Z          1 50.00%   100%          1 50.00%  r1cs.(*r1cs).AssertIsEqual D:\a\gnark\gnark\frontend\cs\r1cs\api_assertions.go:37
2022-11-18T14:27:14.0702392Z want:
2022-11-18T14:27:14.0702509Z 2
2022-11-18T14:27:14.0702729Z Showing nodes accounting for 2, 100% of 2 total
2022-11-18T14:27:14.0702980Z       flat  flat%   sum%        cum   cum%
2022-11-18T14:27:14.0703491Z          1 50.00% 50.00%          2   100%  profile_test.(*Circuit).Define profile/profile_test.go:17
2022-11-18T14:27:14.0704294Z          1 50.00%   100%          1 50.00%  r1cs.(*r1cs).AssertIsEqual frontend/cs/r1cs/api_assertions.go:37
@gbotrel gbotrel added the bug Something isn't working label Nov 18, 2022
@gbotrel gbotrel added this to the v0.9.0 milestone Nov 18, 2022
@gbotrel gbotrel self-assigned this Nov 18, 2022
@gbotrel gbotrel linked a pull request Dec 5, 2022 that will close this issue
fix: fix #400 with trim path handling in profile report #409
Merged
gbotrel added a commit that referenced this issue Dec 5, 2022
@gbotrel
fix: fix #400 with trim path handling in profile report (#409)
610796c 
* fix: detect gnark root path on target for test to work on CI

* fix: fix previous commit for CI
@gbotrel gbotrel modified the milestones: v0.9.0, v0.8.0 Jan 13, 2023
gbotrel added a commit that referenced this issue Jan 13, 2023
@gbotrel
fix: closes #400 path trimming correct, example with unix path separa…
0d0df78 
…tors
@gbotrel gbotrel closed this as completed Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbotrel gbotrel

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

fix: fix #400 with trim path handling in profile report Consensys/gnark
1 participant
@gbotrel