Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: engine.Println to take strings #419

Merged
merged 2 commits into from Dec 19, 2022
Merged

Conversation

Tabaie
Copy link
Contributor

@Tabaie Tabaie commented Dec 16, 2022

Currently such a test fails:

type testPrintCircuit struct {
	Var frontend.Variable
}

func (c *testPrintCircuit) Define(api frontend.API) error {
	api.Println("testing", c.Var)
	api.AssertIsEqual(c.Var, 0)
	return nil
}

func TestPrintSolve(t *testing.T) {
	circuit := testPrintCircuit{}
	assignment := testPrintCircuit{0}
	NewAssert(t).SolvingSucceeded(
		&circuit, &assignment, WithBackends(backend.GROTH16), WithCurves(ecc.BN254))
}

It is useful to have descriptive strings in print statements. This PR enables that.

@Tabaie Tabaie requested a review from gbotrel December 16, 2022 22:58
@gbotrel gbotrel merged commit 935ab13 into develop Dec 19, 2022
@gbotrel gbotrel deleted the fix/engine.println-string branch December 19, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants