Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve upgradeability section #164

Closed
maurelian opened this issue Sep 6, 2018 · 6 comments
Closed

Improve upgradeability section #164

maurelian opened this issue Sep 6, 2018 · 6 comments

Comments

@maurelian
Copy link
Contributor

This post from our friends at Trail of Bits made reference to some outdated content in our best practices.

It definitely needs to be revisited, and in the shorter term, possibly removed or wrapped in a big fat caveat.

@shayanb
Copy link
Contributor

shayanb commented Jan 25, 2019

No links from the mentioned post to Best practices exist at this time.

Related section: https://consensys.github.io/smart-contract-best-practices/software_engineering/

@maurelian
Copy link
Contributor Author

They took it down.... but we should definitely discuss that section's value.

@maurelian
Copy link
Contributor Author

I think the right way to handle this is:

  1. Write a paragraph about the risks and arugments against upgradability
  2. Link to other resources such as those from Zepp and ToB above.

@fodisi
Copy link
Contributor

fodisi commented Jan 3, 2020

Hi,
I'm serving as a Fellow Mentor in the Consensys Academy Blockchain Developer program, and I found this open issue while writing something for the Academy regarding upgradeability.

I just submitted PR #244 with a proposal. I'm fully open to rework it based on the community feedback so we can improve this section.

Thank you.

@shayanb
Copy link
Contributor

shayanb commented Mar 18, 2021

merged in #164

@shayanb shayanb closed this as completed Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@shayanb @maurelian @kadenzipfel @fodisi and others