Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

May need 'payable'? #69

Closed
readytopark opened this issue Dec 7, 2016 · 2 comments
Closed

May need 'payable'? #69

readytopark opened this issue Dec 7, 2016 · 2 comments

Comments

@readytopark
Copy link

In "Keep fallback functions simple" section,

function deposit() external { balances[msg.sender] += msg.value; }

Does't this function need "payable" modifier to work properly?

@simondlr
Copy link
Contributor

simondlr commented Dec 7, 2016

That is correct. Thanks @readytopark.

@ethers ethers closed this as completed in 7673a86 Dec 7, 2016
@ethers
Copy link
Contributor

ethers commented Dec 7, 2016

Thanks you @readytopark! Feel free to submit a pull request if you see payable missing in other areas, or if you have other improvements :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants