Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer select() over poll() on macos for ttys #169

Merged
merged 1 commit into from
May 18, 2023
Merged

Prefer select() over poll() on macos for ttys #169

merged 1 commit into from
May 18, 2023

Conversation

mitsuhiko
Copy link
Collaborator

Turns out that polling on ttys does not work on macos. This now falls back to select if a tty is detected.

Fixes #168

@mitsuhiko mitsuhiko merged commit 66cb2aa into master May 18, 2023
15 checks passed
@mitsuhiko mitsuhiko deleted the feature/select-tty branch May 18, 2023 10:22
@ioquatix
Copy link

kqueue works according to my own tests, but only on modern (past few years) releases of the OS. Before that, there were a lot of issues.

@chriso chriso mentioned this pull request May 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

read_key goes into an endless loop and eventually exhausts file handles
2 participants
@mitsuhiko @ioquatix