Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "unicode-width" dependency actually optional #281

Merged
merged 1 commit into from May 1, 2021

Conversation

Shnatsel
Copy link
Contributor

Fixes #280

This also disables the ansi-parsing feature in console, I don't know if that breaks anything or not.

@djc
Copy link
Collaborator

djc commented May 1, 2021

I checked, and I don't think indicatif uses any of the code paths that rely on ansi-parsing in the console crate.

Thanks for your many contributions to security in Rust's ecosystem! (And for this PR, of course.)

@djc djc merged commit b2f0e8c into console-rs:main May 1, 2021
@Shnatsel Shnatsel deleted the patch-1 branch August 30, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

indicatif depends on unicode-width unconditionally, even though the feature is optional
2 participants