Do not use boxcar windowing when displaying the final total of the speed #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Feb 17, 2022
src/style.rs
Outdated
| .unwrap(), | ||
| "per_sec" => { | ||
| if matches!(&state.status, Status::InProgress) { | ||
| buf.write_fmt(format_args!("{:.4}/s", state.per_sec())) |
There was a problem hiding this comment.
I'm open to this change, but this way seems unnecessarily repetitive. It looks like we can put the logic here into a separate ProgressState method?
There was a problem hiding this comment.
Good point! How about now? Not sure you want it always behave like that but it felt like a good thing to me :) In the end you want the overall speed and not the current one in any case I feel like :)
djc
approved these changes
Feb 18, 2022
|
That's much better, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is especially relevant when speed varies a lot. Then confusing things like this probe-rs/probe-rs#801 can happen. This is unfortunately only barely, if at all, visible in the examples as speed, whilst varying a little, is steady.