Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inc is call before actual work in examples #521

Closed
tatref opened this issue Feb 25, 2023 · 3 comments
Closed

inc is call before actual work in examples #521

tatref opened this issue Feb 25, 2023 · 3 comments

Comments

@tatref
Copy link
Contributor

tatref commented Feb 25, 2023 •
edited

Hi,

In some examples, inc is call before "work", for example in the single.rs example, we call inc, then sleep the next line:

indicatif/examples/single.rs

Line 9 in fb8d0e0

pb.inc(1);

Should it be called after the heavy lifting?
@djc
Copy link
Collaborator

djc commented Feb 26, 2023

Probably. Want to submit a PR?

@tatref
Copy link
Contributor Author

tatref commented Feb 26, 2023

Sure! I just wanted to be sure that my assumption was correct

@tatref tatref mentioned this issue Feb 26, 2023
Merged
@chris-laplante
Copy link
Collaborator

Closing since PR was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@djc @tatref @chris-laplante