Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up GASP #48

Open
constantinpape opened this issue Jan 24, 2022 · 0 comments
Open

Clean up GASP #48

constantinpape opened this issue Jan 24, 2022 · 0 comments

Comments

@constantinpape
Copy link
Owner

Some potential clean-ups as follow up from #47 (I would like to keep all the public functionality functional)

  • Add a functional wrapper for GaspFromAffinities
  • Remove "WatershedFromAffinities"; for simple function wrappers functools.partial can be used
  • Remove build_pixel_long_range_grid_graph_from_offsets in favor of functionality from elf.segmentation.features
  • Remove build_lifted_graph_from_rag in favor of functionality from elf.segmentation.features
  • Use elf.segmentation.compute_rag instead of get_rag (need to think about using the -1 as ignore label)

That's just what I found on first review; there may be some other things deeper in the code.

cc @abailoni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant