Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preference for loading Tutorial View on start-up #808

Closed
1 task
aldebaran30701 opened this issue Aug 25, 2020 · 5 comments
Closed
1 task

Preference for loading Tutorial View on start-up #808

aldebaran30701 opened this issue Aug 25, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers ux Things related to the user experience

Comments

@aldebaran30701
Copy link
Contributor

Prerequisites

Description

There may be a need for the tutorial view to load on start up - I myself find that I end up closing it every application load. Maybe a prompt which asks if you would like to not see it again ?
I pose this as more of a question to gauge interest in the use of this functionality.

@aldebaran30701 aldebaran30701 added enhancement New feature or request good first issue Good for newcomers question Further information is requested ux Things related to the user experience user relevant labels Aug 25, 2020
@arcturus2
Copy link
Collaborator

Hi @aldebaran30701 in Setup -> Options -> Constellation we do have a preference where you can have the tutorial view not show on startup.

@aldebaran30701
Copy link
Contributor Author

I'm happy to close this as it was an oversight. I'll be using this. 👍

@aldebaran30701
Copy link
Contributor Author

aldebaran30701 commented Aug 26, 2020

Reopening this as a prompt for the user may be useful on the tutorial page itself.
ie. Tutorial view has a check box or option to not load it on startup.

@arcturus2 mentioned: "netbeans's startup tab has this feature so we have the source code to be able to do it too by looking at their source code"

@arcturus2
Copy link
Collaborator

It's their "Start Page" and the source code will be https://github.com/apache/netbeans/tree/master/nb/welcome/src/org/netbeans/modules/welcome/ui

image

@formalhaut69 formalhaut69 self-assigned this Aug 26, 2020
@formalhaut69
Copy link
Contributor

This issue is about 90% complete. I've got the checkbox working on the startpage and it looks nice. (This code starts on line 126 of TutorialViewPane)

ShowOnStartUpCheckBox = new CheckBox("Show On Startup");
            rightVBox.getChildren().add(ShowOnStartUpCheckBox);
            rightVBox.setAlignment(Pos.TOP_RIGHT);
            rightVBox.setBackground(new Background(new BackgroundFill(Color.valueOf("#333333"), CornerRadii.EMPTY, Insets.EMPTY)));
            rightVBox.paddingProperty().set(new Insets(5, 5, 5, 5));
            ShowOnStartUpCheckBox.selectedProperty().addListener(new ChangeListener<Boolean>() {
                @Override
                public void changed(ObservableValue<? extends Boolean> ov,
                        Boolean old_val, Boolean new_val) {
                    final Preferences prefs = NbPreferences.forModule(ApplicationPreferenceKeys.class);
                    prefs.putBoolean(ApplicationPreferenceKeys.TUTORIAL_ON_STARTUP, new_val);
                }
            });
            ShowOnStartUpCheckBox.setSelected(true);

The one part I couldn't finish was adding a listener to the on start up preference which can be found in the ApplicationPreferenceKeys class and is called TUTORIAL_ON_STARTUP. The new checkbox which I've added to the TutorialViewPane needs to listen to changes to the preference because there is another checkbox which also modifies the preference in constellation's settings. These need to stay in sync.

@formalhaut69 formalhaut69 removed their assignment Aug 31, 2020
@Polaris5514 Polaris5514 linked a pull request Oct 16, 2020 that will close this issue
@Polaris5514 Polaris5514 added this to To do in Constellation via automation Oct 16, 2020
@Polaris5514 Polaris5514 moved this from To do to PR Review in Constellation Oct 16, 2020
@antares1470 antares1470 removed the question Further information is requested label Oct 25, 2020
@Delphinus8821 Delphinus8821 self-assigned this Oct 25, 2020
@aldebaran30701 aldebaran30701 moved this from PR Review to In progress in Constellation Oct 25, 2020
@Delphinus8821 Delphinus8821 moved this from In progress to PR Review in Constellation Oct 26, 2020
@antares1470 antares1470 removed a link to a pull request Oct 27, 2020
@antares1470 antares1470 moved this from PR Review to Testing in Constellation Oct 29, 2020
Constellation automation moved this from Testing to Done Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers ux Things related to the user experience
Projects
Constellation
  
Done
Development

No branches or pull requests

6 participants