Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle invalid URLs in withUrlParams #331

Closed
StefanoMagrassi opened this issue Nov 2, 2020 · 0 comments · Fixed by #337
Closed

Handle invalid URLs in withUrlParams #331

StefanoMagrassi opened this issue Nov 2, 2020 · 0 comments · Fixed by #337
Assignees
@StefanoMagrassi
Labels
bug
Milestone
4.0.x

Comments

@StefanoMagrassi
Copy link
Contributor

StefanoMagrassi commented Nov 2, 2020 •
edited

Description

The withUrlParams combinator internally uses the URL() constructor which throws an exception when the provided string is not a valid url.

Current behavior

withUrlParams() throws an exception when Request url is not valid.

Expected behavior

withUrlParams() should return a RequestError when Request url is not valid

Environment:

  • OS: all
  • Browser: all
  • Node/npm version: all
  • Typescript version: all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanoMagrassi StefanoMagrassi

Labels
bug
Projects
None yet
Milestone
4.0.x
Development

Successfully merging a pull request may close this issue.

Fix withURLParams() throwing exception when url is invalid contactlab/appy
1 participant
@StefanoMagrassi